Not started Future is now cancellable (#2750) #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivovarit
force-pushed
the
non_started_future_is_cancellable
branch
from
5962a4c to
ad4efc4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2763 +/- ##
============================================
+ Coverage 92.74% 92.75% +0.01%
- Complexity 5247 5260 +13
============================================
Files 89 89
Lines 12538 12539 +1
Branches 1604 1595 -9
============================================
+ Hits 11628 11631 +3
- Misses 721 722 +1
+ Partials 189 186 -3 ☔ View full report in Codecov by Sentry. |
|
Looks good to me :) thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue with not started futures running even if cancelled. (#2750)